Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create recipe.yaml for simplejson #458

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Create recipe.yaml for simplejson #458

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5fe509
Create recipe.yaml for simplejson
tylere May 13, 2023
7b07395
Merge branch 'main' into patch-1
DerThorsten Jun 20, 2023
f3fd8d0
Merge branch 'main' into patch-1
DerThorsten Oct 31, 2023
1600c64
Merge branch 'main' into patch-1
DerThorsten Nov 30, 2023
1948f0b
Merge branch 'main' into patch-1
DerThorsten May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions recipes/recipes_emscripten/simplejson/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
context:
version: 3.19.1

package:
name: simplejson
version: "{{ version }}"

build:
number: 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there are some C part to this library:
https://github.com/simplejson/simplejson/blob/master/simplejson/_speedups.c
shouldn't we also add {{ compiler('c') }} as a build requirement (see https://github.com/conda-forge/simplejson-feedstock/blob/main/recipe/meta.yaml#LL23C7-L23C26) or disable the speed ups with REQUIRE_SPEEDUPS to make it pure python.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@proppy absolutely correct!


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also get the test from the original conda-forge recipe? https://github.com/conda-forge/simplejson-feedstock/blob/main/recipe/meta.yaml#L30-L38

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add such tests in the form of a test_simplejson.py / test_<some_name>.py and test the imports there.
ie:

def test_imports():
    import simplejson
    import simplejson._speedups

source:
- url: https://files.pythonhosted.org/packages/c0/5c/61e2afbe62bbe2e328d4d1f426f6e39052b73eddca23b5ba524026561250/simplejson-{{ version }}.tar.gz
sha256: 6277f60848a7d8319d27d2be767a7546bc965535b28070e310b3a9af90604a4c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing about with license section, see: https://github.com/conda-forge/simplejson-feedstock/blob/main/recipe/meta.yaml#L40-L53

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing about with license section, see: https://github.com/conda-forge/simplejson-feedstock/blob/main/recipe/meta.yaml#L40-L53

Loading