Skip to content
This repository has been archived by the owner on Oct 29, 2022. It is now read-only.

Updating to v2.10.4 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HCLJason
Copy link

Pulled updated source from freetype.org

This doesn't compile as a port without some modification to the entry in tools/ports. I have an incoming PR for that file as well.

Pulled updated source from freetype.org
@kripken
Copy link
Member

kripken commented May 21, 2021

Does this repo, before your PR, have local changes compared to upstream? If not, perhaps as discussed in the other ports we should first switch to upstream?

@HCLJason
Copy link
Author

It does not.

I can make the change to switch to upstream in the emscripten repo's freetype.py file.

@kripken
Copy link
Member

kripken commented May 22, 2021

Thanks @HCLJason - sorry for the back and forth on the different repos, but I think we have a clear plan now in all of them. That is, if they have no changes from their upstreams, and the upstreams are on github or somewhere else reliable, we should switch to use the upstreams first in emscripten (then remove the repos in ports).

Actually, looking at freetype, it looks like their upstream is on sourceforge. But they have an official mirror at https://github.com/freetype/freetype which we can use.

@HinTak
Copy link

HinTak commented Jun 17, 2022

@kripken no, the official place for freetype until recently was GNU savannah. It has moved to gitlab (like some of xorg/x11).

@kripken
Copy link
Member

kripken commented Jun 21, 2022

Thanks @HinTak If upstream is on gitlab, then I think the right thing is to make the emscripten repo point to there, and then we don't need this repo.

@ericoporto
Copy link

ericoporto commented Oct 11, 2022

It's best to use a github mirror, either here or the other one. GitHub is really good at being accessible. But instead of pushing a commit, it's best to push the exact repository.

The ports code can fetch a particular tag reference.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants