Merge pull request #184 from emulsify-ds/exit-on-error-when-repositor…

…y-url-is-invalid

fix: gives user a specific error message when the repository URL does not end in .git

src/handlers/systemInstall.ts

@@ -44,13 +44,21 @@ export async function getSystemRepoInfo(
 ): Promise<(GitCloneOptions & { name: string }) | void> {
   // If a repository and checkout were specified, use that to return system information.
   if (repository && checkout) {
-    const repoName = getGitRepoNameFromUrl(repository);
-    if (repoName) {
-      return {
-        name: repoName,
-        repository,
-        checkout,
-      };
+    try {
+      const repoName = getGitRepoNameFromUrl(repository);
+      if (repoName) {
+        return {
+          name: repoName,
+          repository,
+          checkout,
+        };
+      }
+    } catch (error: unknown) {
+      if (error instanceof Error) {
+        return log('error', error.message, EXIT_ERROR);
+      } else {
+        throw error;
+      }
     }
   }
 

src/util/getGitRepoNameFromUrl.test.ts

@@ -17,11 +17,13 @@ describe('getGitRepoNameFromUrl', () => {
     ).toBe('emulsify-drupal');
   });
 
-  it('can return void if given an invalid git url', () => {
+  it('can throw an Error if given an invalid git url', () => {
     expect.assertions(2);
-    expect(getGitRepoNameFromUrl('')).toBe(undefined);
-    expect(
-      getGitRepoNameFromUrl('https://github.com/emulsify-ds/emulsify-drupal')
-    ).toBe(undefined);
+    expect(() => {
+      getGitRepoNameFromUrl('');
+    }).toThrow(Error);
+    expect(() => {
+      getGitRepoNameFromUrl('https://github.com/emulsify-ds/emulsify-drupal');
+    }).toThrow(Error);
   });
 });

src/util/getGitRepoNameFromUrl.ts

@@ -14,7 +14,7 @@ export default function getGitRepoNameFromUrl(url: string): string | void {
 
   // If no .git extension is provided, then this is an invalid git url.
   if (!gitName.includes('.git')) {
-    return undefined;
+    throw new Error('The repository URL must end in .git.');
   }
   return R.head(gitName.split('.'));
 }