-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: node 20, mv components directory src to root, add emulsify-cor… #117
Merged
callinmullaney
merged 97 commits into
convert-components-to-sdc
from
ui-kit-modular-sass
Sep 10, 2024
Merged
chore: node 20, mv components directory src to root, add emulsify-cor… #117
callinmullaney
merged 97 commits into
convert-components-to-sdc
from
ui-kit-modular-sass
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e as only dependency
…e as only dependency
…e as only dependency
…-ui-kit into ui-kit-modular-sass
…-ui-kit into ui-kit-modular-sass
…-ui-kit into ui-kit-modular-sass
…m:emulsify-ds/emulsify-ui-kit into emulsif-236-convert-images-to-support-sdc
…m:emulsify-ds/emulsify-ui-kit into emulsif-241-convert-pager-to-support-sdc
…o-support-sdc EMULSIF-236: Convert Images to support SDC
…-support-sdc EMULSIF-241: Convert Pager to support SDC
…o-support-sdc EMULSIF-242: Convert Status to support SDC
…o-support-sdc EMULSIF-243: Convert Tables to support SDC
…support-sdc EMULSIF-244: Convert Tabs to support SDC
…support-sdc EMULSIF-245: Convert Text to support SDC
…o-support-sdc EMULSIF-246: Convert Videos to support SDC
callinmullaney
added
🎉 Ready to Merge
Functionality is approved by the reviewer.
and removed
🚧 Work in Progress
The PR is a work in progress.
labels
Sep 9, 2024
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e as only dependency
Summary
This PR fixes/implements the following bugs/features
.nvmrc
file to node 20emulsify-core
as the only dependency - aside from ui-kit-specific dev dependencies@use
and@forward
instead of@import
components
directory to the root fromsrc/components
- the cli expectscomponents
to live in the rootimages
directory name toassets
Explain the motivation for making this change. What existing problem does the pull request solve?
Documentation update (required)
If this pull request requires a change to Emulsify documentation, those changes, updates, and/or new information must accompany this pull request.
How to review this pull request
node_modules
directory -rm -rf node_modules
npm install
npm run develop
and make sure Storybook runs properlynpm run build
and make sure everything builds as it shouldClosing issues
Closes #