Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMULSIF-246: Convert Videos to support SDC #149

Merged

Conversation

robherba
Copy link
Contributor

Summary

This PR updates the yml file and stories.js file of the video component to meet the schema the Single Directory Component uses it

How to review this pull request

@robherba robherba added the 👍 Ready for Review Work is ready for review. label Aug 19, 2024
@robherba robherba self-assigned this Aug 19, 2024
@robherba robherba changed the title Emulsif 246 convert videos to support sdc EMULSIF-246: Convert Videos to support SDC Aug 19, 2024
@callinmullaney callinmullaney added 🎉 Passes Code Review Code is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Aug 28, 2024
@callinmullaney callinmullaney changed the base branch from convert-components-to-sdc to ui-kit-modular-sass August 28, 2024 16:18
@callinmullaney callinmullaney merged commit 310f992 into ui-kit-modular-sass Aug 28, 2024
1 check failed
@callinmullaney callinmullaney deleted the emulsif-246-convert-videos-to-support-sdc branch August 28, 2024 16:19
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Passes Code Review Code is approved by the reviewer. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants