WRQ-17933: Add unit tests for screenTypes matching supported resolutions #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/4.7.x.develop #3229 +/- ##
=========================================================
+ Coverage 82.16% 82.21% +0.04%
=========================================================
Files 155 155
Lines 7173 7173
Branches 1891 1891
=========================================================
+ Hits 5894 5897 +3
+ Misses 1003 1001 -2
+ Partials 276 275 -1 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
As we support new resolution type QHD, we decided to test all supported screen types.
Resolution
Because TV model which needs for QHD is based on enact 4.7.x version, this PR is for release/4.7.x.develop branch.
I copied changed code of #3228
added unit tests for screenTypes of supported resolutions.
Additional Considerations
Links
WRQ-17933
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])