Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-17933: Support QHD resolution #1599

Merged
merged 1 commit into from
May 3, 2024

Conversation

vJIYEv
Copy link
Contributor

@vJIYEv vJIYEv commented Apr 24, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

We need to support QHD resolution for TV.

Resolution

Because TV model which needs for QHD is based on sandstone 2.7.x version, this PR is for release/2.7.x.develop branch.
I copied changed code of #1596

added QHD type in screenTypes.json file.

Additional Considerations

Links

WRQ-17933

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])

Enact-DCO-1.0-Signed-off-by: Jiye Kim ([email protected])
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (bf799f2) to head (06edffe).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           release/2.7.x.develop    #1599   +/-   ##
======================================================
  Coverage                  80.46%   80.46%           
======================================================
  Files                        142      142           
  Lines                       6497     6497           
  Branches                    1919     1919           
======================================================
  Hits                        5228     5228           
  Misses                       966      966           
  Partials                     303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mmyelyn mmyelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Copy link
Contributor

@juwonjeong juwonjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juwonjeong juwonjeong merged commit 4badb56 into release/2.7.x.develop May 3, 2024
5 checks passed
@juwonjeong juwonjeong deleted the feature/WRQ-17933-2.7 branch May 3, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants