-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRR-1063: Added a QA sampler for Spotlight.focus
with preventScroll
option
#1697
Conversation
…l` option Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1697 +/- ##
========================================
Coverage 80.92% 80.92%
========================================
Files 148 148
Lines 6685 6685
Branches 2001 2001
========================================
Hits 5410 5410
Misses 969 969
Partials 306 306 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
Issue Resolved / Feature Added
Spotlight.focus
supportspreventScroll
option from enactjs/enact#3277. It looks better to add a sampler case to test this API in Sandstone.Resolution
A new sampler case is created to compare behaviors with
preventScroll
option and withoutpreventScroll
option.Additional Considerations
Links
WRR-1063
enactjs/enact#3277
Comments
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])