Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-6380: Converted Popup/Popup to functional component #1734

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

WRR-6380: Converted Popup/Popup to functional component #1734

Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
69c9bbb
Converted `Popup` to functional component
ion-andrusciac-lgp Oct 16, 2024
e5cfb74
Fixed lint warnings
ion-andrusciac-lgp Oct 16, 2024
2f72395
Deleted `...rest` props
ion-andrusciac-lgp Oct 16, 2024
cc86ba6
Fixed focus issues
ion-andrusciac-lgp Oct 17, 2024
91ce7aa
Fixed cleanup function
ion-andrusciac-lgp Oct 17, 2024
95494c7
Fixed lint warnings
ion-andrusciac-lgp Oct 17, 2024
461e1a4
Extracted props from `handleKeyDown`
ion-andrusciac-lgp Oct 18, 2024
2e5c79d
Code refactor
ion-andrusciac-lgp Oct 18, 2024
88aaee4
Added target for the `on` and `off` listeners
ion-andrusciac-lgp Oct 18, 2024
f36c087
Created reference for `handleKeyDown` function
ion-andrusciac-lgp Oct 21, 2024
d51f921
Created reference for `containerId` only when component is mounted
ion-andrusciac-lgp Oct 22, 2024
b562900
Component refactor
ion-andrusciac-lgp Oct 22, 2024
0426396
Added `useEffect` to spot the Popup content after it's mounted and open
ion-andrusciac-lgp Oct 22, 2024
96a62b4
Added default value for `containerId`
ion-andrusciac-lgp Oct 22, 2024
c3a3ade
Added `Pause` class in `useState` instead of `useRef`
ion-andrusciac-lgp Oct 23, 2024
c9ca422
Changed condition for `spotActivator`
ion-andrusciac-lgp Oct 23, 2024
293f95c
Changed condition for `spotActivator`
ion-andrusciac-lgp Oct 23, 2024
1729bb7
Fixed lint warnings
ion-andrusciac-lgp Oct 23, 2024
5c06c2f
Moved `Pause` class into `useRef`
ion-andrusciac-lgp Oct 23, 2024
ad7008b
Merge branch 'develop' of https://github.com/enactjs/sandstone into f…
ion-andrusciac-lgp Oct 23, 2024
a1a2e85
Fixed focus issues on Popup and refactored the code
ion-andrusciac-lgp Oct 24, 2024
8d29d81
Fixed focus issues on Input
ion-andrusciac-lgp Oct 24, 2024
36162d3
Forced `Spotlight` to focus the last focused element when the `Popup`…
ion-andrusciac-lgp Oct 24, 2024
4f96a9c
Fixed lint warnings
ion-andrusciac-lgp Oct 24, 2024
421211b
Added condition to focus `activator` when the `Popup` is closed and r…
ion-andrusciac-lgp Oct 25, 2024
2bb8941
Merge branch 'develop' of https://github.com/enactjs/sandstone into f…
ion-andrusciac-lgp Oct 25, 2024
120af63
Changed the comment for `handleComponentUpdate` function
ion-andrusciac-lgp Oct 25, 2024
7b5e6c7
Review fixes
ion-andrusciac-lgp Oct 31, 2024
ddd7a63
Review fixes
ion-andrusciac-lgp Oct 31, 2024
19935d1
Fixed lint warnings
ion-andrusciac-lgp Oct 31, 2024
93c8dcb
Review fixes
ion-andrusciac-lgp Nov 1, 2024
5b0556d
Fixed `eventListeners`
ion-andrusciac-lgp Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading