Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-109159: Fix to position the NavigationButtons properly in FixedPopupPanels in RTL #438

Merged
merged 28 commits into from
Jun 12, 2020
Merged

PLAT-109159: Fix to position the NavigationButtons properly in FixedPopupPanels in RTL #438

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
b33c070
Fix to keep current location in LTR and RTL
ybsung Jun 11, 2020
766358d
Update CHANGELOG.md
ybsung Jun 11, 2020
42d3572
Revert "Fix to keep current location in LTR and RTL"
ybsung Jun 11, 2020
69b3558
Pass flip prop from FlexiblePopup's panel to Icon
ybsung Jun 11, 2020
49a594b
Adjust the navigation button position in FlexiblePopupPanels
ybsung Jun 11, 2020
aea6766
Update CHANGELOG.md
ybsung Jun 11, 2020
d0b4897
Fix lint
ybsung Jun 11, 2020
8436a71
Fix panel position
ybsung Jun 11, 2020
35c05fd
Update .travis.yml
ybsung Jun 11, 2020
8426e70
Fix lint
ybsung Jun 11, 2020
c92bd57
Revert "Update .travis.yml"
ybsung Jun 11, 2020
96858bc
Replace iconProps with iconComponent
ybsung Jun 11, 2020
f67e77b
Merge branch 'develop' into feature/PLAT-109159-yb
ybsung Jun 11, 2020
ac99e91
Fix lint
ybsung Jun 11, 2020
ebf71e1
Fix lint
ybsung Jun 11, 2020
e0d576a
Fix
ybsung Jun 11, 2020
c08e524
Fix navButton position
ybsung Jun 11, 2020
cb6d3e5
Merge branch 'develop' into feature/PLAT-109159-yb
ybsung Jun 11, 2020
45bcc08
add iconFlip
Jun 12, 2020
edd6bab
remove iconComponent override
Jun 12, 2020
1cba727
clean up Button
Jun 12, 2020
a796789
fix change log
Jun 12, 2020
d253ded
migrate auto-flip to sandstone
Jun 12, 2020
8ab9b31
document rtl LESS
Jun 12, 2020
f948cb7
add SSTs for flip and iconFlip
Jun 12, 2020
61b9735
update docs
Jun 12, 2020
c90c819
fix unit tests
Jun 12, 2020
dfac0ac
change log
Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ The following is a curated list of changes in the Enact sandstone module, newest

### Fixed

- `sandstone/FixedPopupPanels` to keep current location in LTR and RTL
- `sandstone/TabLayout` performance when focusing items in the layout

## [1.0.0-beta.6] - 2020-06-08
Expand Down
4 changes: 4 additions & 0 deletions FlexiblePopupPanels/FlexiblePopupPanels.module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,8 @@
filter: drop-shadow(@sand-flexiblepopuppanels-panel-shadow);
}
});

:global(.enact-locale-right-to-left) & {
direction: ltr;
}
}