Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ser::to_vec() for convenient serializing into a new Vec<u8> #128

Closed
wants to merge 1 commit into from

Conversation

Voker57
Copy link

@Voker57 Voker57 commented Jun 14, 2024

such shortcut is usually included in serde format libraries

…ec<u8>

such shortcut is usually included in serde format libraries

Signed-off-by: Iaroslav Gridin <[email protected]>
@Voker57 Voker57 requested a review from a team as a code owner June 14, 2024 11:03
@Voker57 Voker57 requested a review from haraldh June 14, 2024 11:03
@rjzak
Copy link
Member

rjzak commented Jul 4, 2024

This won't work as-is because Ciborium aims to work in no_std environments, and vec! requires std. Feel free to re-work and re-open if you wish. Perhaps it could be gated on #[cfg_attr(feature = "std")]

@rjzak rjzak closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants