feat: deserialize bytes from Value Array #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a unit test which shows this working? |
|
Ok, last thing. Could you squash your commits and update the commit message? The PR title looks great, but the commisery check is upset. Otherwise, looks good. |
Signed-off-by: Liam Perlaki <[email protected]>
lperlaki
force-pushed
the
bytes-from-array
branch
from
5c38e5f
to
a9045e5
Compare
|
Thank you for the quick responses. |
rjzak
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to deserialize bytes from a
Value::Array(Integer)matches the behaviour of serve_json
should we also allow to deserialize bytes from
Value::Text?