Add impl TryFrom<&[u8]> and other methods for SigData #14
Conversation
lkatalin
changed the title
src/attestation_types/quoteheader.rs
Outdated
| //! The QuoteHeader is part of the Quote structure. See the Quote module for more. | ||
|
|
||
| use super::quote::QuoteError; | ||
| use std::convert::TryFrom; |
There was a problem hiding this comment.
you might get rid of std by using core::convert::TryFrom
src/attestation_types/mod.rs
Outdated
| @@ -6,5 +6,12 @@ | |||
|
|
|||
| #[cfg(feature = "std")] | |||
| pub mod quote; | |||
|
|
|||
| #[cfg(feature = "std")] | |||
src/attestation_types/sigdata.rs
Outdated
|
|
||
| /// A.4, Table 4 | ||
| #[derive(Default)] | ||
| #[repr(C)] |
There was a problem hiding this comment.
I don't think this makes sense with Vec.
There was a problem hiding this comment.
If it can't be #[repr(c)] then I may need to have a different version of the struct that's created from this original once the size is known. Maybe a debt issue...
There was a problem hiding this comment.
Why do you need #[repr(C)] ? for FFI?
There was a problem hiding this comment.
Yeah, this may potentially get passed around between Rust and C.
There was a problem hiding this comment.
It may also be possible in the near future to remove the vec fields, which would be ideal. Although the Quote can change in size, I think the version we're using will always be the same size. But I have to test that theory.
src/attestation_types/quote.rs
Outdated
| report::{Body, ReportError}, | ||
| sigdata::SigData, | ||
| }; | ||
| use std::fmt; |
There was a problem hiding this comment.
could use core::fmt and get rid of std
Signed-off-by: Lily Sturmann <[email protected]>
enarxbot
assigned connorkuehl, whitebrandy, haraldh and npmccallum and unassigned lkatalin
Note that the size of
SigDataisn't known at compilation time, so animpl TryFrom<&[u8]> for SigDatais appropriate.I'm also open to making some of the byte lengths, etc., into constants, but there are so many that I thought it would just be even less readable. Open to suggestions on this.
Related to enarx/enarx#917
related to enarx/enarx#84