Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting postcss-url maxSize #128

Merged
merged 1 commit into from
Aug 9, 2016

Conversation

smdenis
Copy link

@smdenis smdenis commented Jul 25, 2016

Makes possible setting postcss-url option maxSize. #85

@smdenis smdenis force-pushed the feature/smdenis.maxSize branch from 4d43356 to 1eb0a10 Compare July 25, 2016 16:22
@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 1eb0a10 on creedencewright:feature/smdenis.maxSize into c188ae7 on enb:master.

@emelyanovtv
Copy link

🆗

@@ -96,6 +96,7 @@ module.exports = buildFlow.create()
.name('stylus')
.target('target', '?.css')
.defineOption('url', 'rebase')
.defineOption('inlineMaxSize', undefined)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

option undefined by default

@blond
Copy link
Member

blond commented Aug 9, 2016

Need add docs about option to API and update url docs.

@smdenis smdenis force-pushed the feature/smdenis.maxSize branch from 1eb0a10 to 74a4be7 Compare August 9, 2016 13:12
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 74a4be7 on creedencewright:feature/smdenis.maxSize into c188ae7 on enb:master.

@smdenis
Copy link
Author

smdenis commented Aug 9, 2016

@blond,
fixed.


Тип: `String`. По умолчанию: `''`.

Максимальный размер файла, который будет закодирован в base64 в режиме `rebase`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

режиме rebase -> режиме inline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

надо добавить что размер в kbytes

@smdenis smdenis force-pushed the feature/smdenis.maxSize branch from 74a4be7 to f066a1a Compare August 9, 2016 13:34
@smdenis
Copy link
Author

smdenis commented Aug 9, 2016

@blond, поправил.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f066a1a on creedencewright:feature/smdenis.maxSize into c188ae7 on enb:master.

@blond
Copy link
Member

blond commented Aug 9, 2016

👍

@blond blond merged commit 23fa095 into enb:master Aug 9, 2016
@blond
Copy link
Member

blond commented Aug 9, 2016

Выпустил v2.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants