Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .exists() #17

Merged
merged 4 commits into from
Mar 29, 2019
Merged

Add .exists() #17

merged 4 commits into from
Mar 29, 2019

Conversation

florimondmanca
Copy link
Member

Fixes #5

tomchristie
tomchristie reviewed Mar 26, 2019
View reviewed changes
orm/models.py Outdated Show resolved Hide resolved
tomchristie
tomchristie reviewed Mar 26, 2019
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Thank you.
A few questions just to clarify stuff.

orm/models.py Outdated Show resolved Hide resolved
tests/test_models.py Outdated Show resolved Hide resolved
@tomchristie
Copy link
Member

Okay, so databases 0.2.1 now supports fetch_val - let's switch to using that.
Then I think this is good to go. 👍

@tomchristie tomchristie mentioned this pull request Mar 27, 2019
Merged
@florimondmanca
Copy link
Member Author

I pushed a fix for this one and #18 👍 There will definitely be merge conflicts so let's merge either one and I'll fix the conflicts afterwards.

@tomchristie
Copy link
Member

Okay - merged #18

@florimondmanca
Copy link
Member Author

Cool, I rebased the changes and fixed the merge conflicts! 👍 Same on #16.

@tomchristie tomchristie merged commit ba83b4f into encode:master Mar 29, 2019
@florimondmanca florimondmanca deleted the exists branch March 29, 2019 13:55
@tomchristie
Copy link
Member

Great! Published as 0.1.4. I'll need to review #16 some other time - perhaps taking another look at how to tie it in neatly with typesystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florimondmanca @tomchristie