More predictable timeout-notify with slow sync calls #2625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The timeout-notify mechanism is less predictable than necessary when slow synchronous calls are run on the event loop thread. This can lead to uvicorn workers being killed by (for example) gunicorn while they're still responsive.
The uvicorn servers
main_loop
triggerson_tick
and sleeps asynchronously for 0.1 seconds. Every 10 tickson_tick
checks if it's time to runcfg.callback_notify
. The comments in the code imply that the check is supposed to run once every second, but if there are synchronous calls blocking the asynchronous sleeps from triggering in a timely manner, the actual cadence can be a lot slower.Of course, you're not supposed to block the event loop like that, but checking the need to notify on each tick (every 0.1+ seconds) improves the situation at a negligible cost.
Checklist