-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Worker
api and make it work against recent integritee-worker (aka tls directly into the enclave)
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
changed the title
Incognitee Support
Rework Apr 10, 2024
Worker
api and make it work against recent integritee-worker (aka tls directly into the enclave)
clangenb
commented
Apr 10, 2024
// Enforce using the pure javascript implementations by | ||
// setting the `browser` environment, as compatibility | ||
// with node's crypto is broken and leads to bad outputs. | ||
environment: 'browser', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes #90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the worker api into the new design implemented in the worker, which moved the TLS endpoint to inside the enclave, and has changed the API in general. Closes #86, #90. Additionally, it lays the foundation of separate worker implementation by distinguishing between the overarching base
Worker
implementing theIWorker
interface. Then we have two different worker implementations, theIntegriteeWorker
and theEncointerWorker
. Although, some functions are not generic enough to support both yet, and hence theEncointerWorker
is not functional, as it uses types for theIntegriteeWorker
, tracking issue #91.Working
state_executeGetter
: trusted nonce getter, trusted balance getterauthor_submitExrinsic
:trustedBalanceTransfer
,balanceUnshield
Note
author_submitAndWatchExtrinsic