Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Worker api and make it work against recent integritee-worker (aka tls directly into the enclave) #89

Merged
merged 41 commits into from
Apr 10, 2024

Conversation

clangenb
Copy link
Member

@clangenb clangenb commented Apr 6, 2024

This PR reworks the worker api into the new design implemented in the worker, which moved the TLS endpoint to inside the enclave, and has changed the API in general. Closes #86, #90. Additionally, it lays the foundation of separate worker implementation by distinguishing between the overarching base Worker implementing the IWorker interface. Then we have two different worker implementations, the IntegriteeWorker and the EncointerWorker. Although, some functions are not generic enough to support both yet, and hence the EncointerWorker is not functional, as it uses types for the IntegriteeWorker, tracking issue #91.

Working

  • Handle self-signed certificate in node-js tests
  • get shielding key
  • get shard vault
  • trusted balance getter
  • state_executeGetter: trusted nonce getter, trusted balance getter
  • author_submitExrinsic: trustedBalanceTransfer, balanceUnshield

Note

  • There is no support for subscribing to results of a trusted call with author_submitAndWatchExtrinsic

@clangenb clangenb marked this pull request as draft April 6, 2024 05:56
@clangenb clangenb changed the title Incognitee Support Rework Worker api and make it work against recent integritee-worker (aka tls directly into the enclave) Apr 10, 2024
@clangenb clangenb marked this pull request as ready for review April 10, 2024 02:56
@clangenb clangenb merged commit 5d9a714 into master Apr 10, 2024
2 of 3 checks passed
// Enforce using the pure javascript implementations by
// setting the `browser` environment, as compatibility
// with node's crypto is broken and leads to bad outputs.
environment: 'browser',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #90

@clangenb clangenb deleted the cl/incognitee-support branch April 17, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EncointerWorker connection fails at TLS handshake (websocket close reason 1015)
1 participant