misc: Make page token required #813
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test report (Pydantic 1.x)189 tests 189 ✅ 5s ⏱️ Results for commit 7452469. ♻️ This comment has been updated with latest results. |
Unit test report ((Pydantic 2.x)189 tests 189 ✅ 6s ⏱️ Results for commit 7452469. ♻️ This comment has been updated with latest results. |
Jim-Encord
force-pushed
the
jb/make-page-token-required
branch
from
728f73a to
7452469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction and Explanation
Following Abhi's issue wherein he was providing the page token against the wrong field, how can we defend against this?
By using required fields where possible. Let's see if we can make this required.
Tests
We'll see if this fails against the integration tests. All integration test pass except for known flake.
Known issues
May break stuff that we don't test.