Skip to content

Commit

Permalink
Update notify-rs to fix WSL crash
Browse files Browse the repository at this point in the history
Fixes #66
  • Loading branch information
encounter committed Jun 4, 2024
1 parent a5a6a39 commit 79cd460
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 15 deletions.
22 changes: 15 additions & 7 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,5 @@ resolver = "2"

[profile.release-lto]
inherits = "release"
# Temporarily disabled to fix notify crash
# See https://github.com/encounter/objdiff/issues/66
#lto = "thin"
lto = "thin"
strip = "debuginfo"
2 changes: 1 addition & 1 deletion objdiff-cli/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "objdiff-cli"
version = "2.0.0-alpha.3"
version = "2.0.0-alpha.4"
edition = "2021"
rust-version = "1.70"
authors = ["Luke Street <[email protected]>"]
Expand Down
2 changes: 1 addition & 1 deletion objdiff-core/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "objdiff-core"
version = "2.0.0-alpha.3"
version = "2.0.0-alpha.4"
edition = "2021"
rust-version = "1.70"
authors = ["Luke Street <[email protected]>"]
Expand Down
4 changes: 2 additions & 2 deletions objdiff-gui/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "objdiff-gui"
version = "2.0.0-alpha.3"
version = "2.0.0-alpha.4"
edition = "2021"
rust-version = "1.70"
authors = ["Luke Street <[email protected]>"]
Expand Down Expand Up @@ -37,7 +37,7 @@ float-ord = "0.3.2"
font-kit = "0.13.0"
globset = { version = "0.4.14", features = ["serde1"] }
log = "0.4.21"
notify = "6.1.1"
notify = { git = "https://github.com/encounter/notify", rev = "4c1783e8e041b5f69d4cf1750b9f07e335a0771e" }
objdiff-core = { path = "../objdiff-core", features = ["all"] }
png = "0.17.13"
pollster = "0.3.0"
Expand Down
2 changes: 1 addition & 1 deletion objdiff-gui/src/views/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ pub fn config_ui(
|| {
Box::pin(
rfd::AsyncFileDialog::new()
.set_directory(&target_dir)
.set_directory(target_dir)
.add_filter("Object file", &["o", "elf", "obj"])
.pick_file(),
)
Expand Down

0 comments on commit 79cd460

Please sign in to comment.