Guard against symbols larger than section

encounter · Aug 11, 2024 · cf937b0 · cf937b0
1 parent 23b6d33
commit cf937b0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/objdiff-core/src/diff/data.rs b/objdiff-core/src/diff/data.rs
@@ -48,8 +48,10 @@ pub fn diff_data_section(
     right_section_diff: &ObjSectionDiff,
 ) -> Result<(ObjSectionDiff, ObjSectionDiff)> {
     let deadline = Instant::now() + Duration::from_secs(5);
-    let left_max = left.symbols.iter().map(|s| s.section_address + s.size).max().unwrap_or(0);
-    let right_max = right.symbols.iter().map(|s| s.section_address + s.size).max().unwrap_or(0);
+    let left_max =
+        left.symbols.iter().map(|s| s.section_address + s.size).max().unwrap_or(0).min(left.size);
+    let right_max =
+        right.symbols.iter().map(|s| s.section_address + s.size).max().unwrap_or(0).min(right.size);
     let left_data = &left.data[..left_max as usize];
     let right_data = &right.data[..right_max as usize];
     let ops =