Improve dependency gating on objdiff-core #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark as many dependencies as optional as I could without actually touching the code.
The way I tested this was to mark every dependency as optional and then try to build
objdiff-core
with each individual feature, and then added each dependency as the build complained about missing stuff.A remarkable thing I noted is that I wasn't able to build any of the architectures on its own besides
ppc
because of this error:So to test every other architecture I had to enable
ppc
too. Because of thisany-arch
can't be built on its own either (kinda makes sense, but weird either way).Finally, I used the
dep:
syntax when listing dependencies on the features out of habit. I can remove those if you prefer.