Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMv5TE (DS) support #68

Merged
merged 21 commits into from
Jun 4, 2024
Merged

ARMv5TE (DS) support #68

merged 21 commits into from
Jun 4, 2024

Conversation

AetiasHax
Copy link
Contributor

I've added support for ARMv5TE, used by the main ARM9 processor of the DS. The disassembler library can be extended to support other ARM versions, and I have plans to add ARMv4T for GBA soon, followed by ARMv6 for the 3DS.

There's currently no version detection in place. This document from ARM does specify where version information should be stored (see Tag_CPU_name), but in my experience working with the DS toolchain, I found no such information. Would a dropdown in the "Arch Settings" window be acceptable?

@encounter
Copy link
Owner

encounter commented Jun 1, 2024

Thanks for the PR! Looks good at an initial glance, but I’d like to revert the unnecessary README changes, especially the changes to config file example, since that’s not valid JSON. 🙂

@encounter
Copy link
Owner

Would a dropdown in the "Arch Settings" window be acceptable?

Yes, this seems like a good solution, though auto-detection would be nice eventually (if possible). It could be similar to the MIPS settings, where it has an “Auto” option, but can be set manually.

@AetiasHax
Copy link
Contributor Author

AetiasHax commented Jun 1, 2024

Thanks for the PR! Looks good at an initial glance, but I’d like to revert the unnecessary README changes, especially the changes to config file example, since that’s not valid JSON. 🙂

That's weird, I don't know how that commit happened. Fixing!

Edit: Looks like it was formatted automatically upon saving, sorry about that.

@AetiasHax
Copy link
Contributor Author

Would a dropdown in the "Arch Settings" window be acceptable?

Yes, this seems like a good solution, though auto-detection would be nice eventually (if possible). It could be similar to the MIPS settings, where it has an “Auto” option, but can be set manually.

In that case, I could implement auto-detection in a non-standard way for the "Auto" option. Possibly by looking at the compiler name/version, or something of the sort.

@encounter
Copy link
Owner

Thanks a ton for this work! Merging for 2.0.0-alpha.3

@encounter encounter merged commit b991960 into encounter:main Jun 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants