ARMv4T (GBA) and ARMv6K (3DS) support #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # objdiff-core/src/arch/x86.rs
- Properly handles multiple sections in DWARF 1 - line_info moved into ObjSection - DWARF 2 parser no longer errors with no .text section - Both parsers properly skip empty sections
This reverts commit 8bbfcc6.
encounter
reviewed
Jun 19, 2024
|
Thanks a ton for this work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented support for v4T (GBA) and v6K (3DS) and tested with
agbccandarmcc. Both compilers emit the .ARM.attributes section, which makes it possible to auto-detect the ARM version being used. Parsing the section was more complicated than I was hoping, so I developed a new crate calledarm-attrto do the magic for us.Since
mwcc(DS compiler) doesn't emit the attributes section, the ARM version falls back to v5TE when no version info is found. If needed, there's a dropdown in "Arch Settings" to override any auto-detection.agbccsets the LSB for Thumb symbols, which meant that all Thumb code was shifted over by one byte and got displayed wrong. To solve this, I've addedObjArch::symbol_addresswhich is called when resolving symbols, andObjArchArmoverrides the default behavior by clearing the LSB.