Combine data sections with equal names #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encounter
reviewed
Jun 19, 2024
| relocations.push(ObjReloc { | ||
| flags: reloc.flags, | ||
| address: (reloc.address as i64 + address_change).try_into()?, | ||
| target: reloc.target, // TODO: Should be updated? |
There was a problem hiding this comment.
Yeah, this is tricky. Would probably require keeping track of every symbol and their adjusted address. Luckily this only affects the relocation display on hover, so this can be revisited later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers such as
mwccarmcan generate multiple.datasections in the same object file, but clicking a data symbol in objdiff shows a hex view for only the first.datasection. Meanwhile, the target object has only one.datasection, so the hex view is diffing all of the target data with only a single chunk of base object data.My proposed solution is to "combine" sections with equal names, ordered from lowest to highest section index. There's a checkbox under "Diff Options" to enable this when needed.