-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Add IPv6 Support to CidrMatch using ipaddress lib #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Justin Ibarra <[email protected]>
Co-authored-by: Justin Ibarra <[email protected]>
eric-forte-elastic
requested review from
Mikaayenson,
brokensound77 and
terrancedejesus
October 30, 2023 14:38
Mikaayenson
reviewed
Oct 30, 2023
Mikaayenson
reviewed
Oct 30, 2023
Mikaayenson
reviewed
Oct 30, 2023
Mikaayenson
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small nits, but LGTM.
brokensound77
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments otherwise, LGTM 👍
terrancedejesus
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates https://github.com/elastic/ia-trade-team/issues/196
Alternative to #77 where the ipaddres library is used instead.
Testing
The majority of the testing can be performed via the new
ipv6
labeled unit tests intest_python_engine.py
andtest_cidrmatch
intest_functions.py
. However, additional testing can be performed by calling the functions directly from a python script.Example Python Script
🔴 Important 🔴
The testing MUST be performed on both Python 3.7 and Python 2.7 as eql needs to be able to support both. Some editors such VSCode do not support debugging in Python 2.7 so one will have to run the unit tests via another method.
To install eql in a Python2 test environment you can follow the following steps (there are other ways to test too, but this can help get started)
virtualenv --python=python2.7 test_two_venv
source /test_two_venv/bin/activate
pip install setuptools -U
mv /home/forteea1/.pypirc ~/pypirc
python setup.py install
python test.py