Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate AppData file failed on Flathub #46

Closed
starnight opened this issue Sep 13, 2023 · 2 comments · Fixed by #48
Closed

Validate AppData file failed on Flathub #46

starnight opened this issue Sep 13, 2023 · 2 comments · Fixed by #48
Assignees
@starnight
Labels
bug Something isn't working

Comments

@starnight
Copy link
Contributor

<caption> cannot end in '.' in app's metainfo

flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/org.endlessos.Key.appdata.xml
 in dir /srv/buildbot/worker/build-x86_64-5/build (timeout 1200 secs)
 watching logfiles {}
 argv: b'flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/org.endlessos.Key.appdata.xml'
 using PTY: False
builddir/files/share/appdata/org.endlessos.Key.appdata.xml: FAILED:
• style-invalid         : <caption> cannot end in '.' [Completely free; access without an account, safeguarded data, and no ads.]
• style-invalid         : <caption> cannot end in '.' [Engaging and interactive; discover an abundance of ready-made resources, games, simulations, etc.]
Validation of files failed

CI: https://buildbot.flathub.org/#/builders/25/builds/8069
@starnight starnight added the bug Something isn't working label Sep 13, 2023
@starnight starnight self-assigned this Sep 13, 2023
@starnight
Copy link
Contributor Author

This is for Publish the Endless Key app on Flathub's PR Add org.endlessos.Key.

starnight added a commit that referenced this issue Sep 13, 2023
@starnight
Drop ending dot of Caption objects
278b652 
Validate AppData file failed on Flathub, because metainfo's <caption>
objects cannot end in '.'.

flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/org.endlessos.Key.appdata.xml
 in dir /srv/buildbot/worker/build-x86_64-5/build (timeout 1200 secs)
 watching logfiles {}
 argv: b'flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/org.endlessos.Key.appdata.xml'
 using PTY: False
builddir/files/share/appdata/org.endlessos.Key.appdata.xml: FAILED:
• style-invalid         : <caption> cannot end in '.' [Completely free; access without an account, safeguarded data, and no ads.]
• style-invalid         : <caption> cannot end in '.' [Engaging and interactive; discover an abundance of ready-made resources, games, simulations, etc.]
Validation of files failed

So, drop the ending dots.

Fixes: #46
@starnight starnight mentioned this issue Sep 13, 2023
Merged
@starnight
Copy link
Contributor Author

New test org.endlessos.Key flatpak v0.3 is built as the testing version on Flathub. flathub/flathub#4481 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@starnight starnight

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop ending dot of Caption objects endlessm/endless-key-flatpak
1 participant
@starnight