Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ending dot of Caption objects #48

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

starnight
Copy link
Contributor

Validate AppData file failed on Flathub, because metainfo's objects cannot end in '.'.

flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/org.endlessos.Key.appdata.xml
 in dir /srv/buildbot/worker/build-x86_64-5/build (timeout 1200 secs)
 watching logfiles {}
 argv: b'flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/org.endlessos.Key.appdata.xml'
 using PTY: False
builddir/files/share/appdata/org.endlessos.Key.appdata.xml: FAILED:
• style-invalid         : <caption> cannot end in '.' [Completely free; access without an account, safeguarded data, and no ads.]
• style-invalid         : <caption> cannot end in '.' [Engaging and interactive; discover an abundance of ready-made resources, games, simulations, etc.]
Validation of files failed

So, drop the ending dots.

Fixes: #46

Validate AppData file failed on Flathub, because metainfo's <caption>
objects cannot end in '.'.

flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/org.endlessos.Key.appdata.xml
 in dir /srv/buildbot/worker/build-x86_64-5/build (timeout 1200 secs)
 watching logfiles {}
 argv: b'flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/org.endlessos.Key.appdata.xml'
 using PTY: False
builddir/files/share/appdata/org.endlessos.Key.appdata.xml: FAILED:
• style-invalid         : <caption> cannot end in '.' [Completely free; access without an account, safeguarded data, and no ads.]
• style-invalid         : <caption> cannot end in '.' [Engaging and interactive; discover an abundance of ready-made resources, games, simulations, etc.]
Validation of files failed

So, drop the ending dots.

Fixes: #46
@starnight starnight self-assigned this Sep 13, 2023
@erikos erikos requested a review from pwithnall September 13, 2023 07:16
@starnight starnight mentioned this pull request Sep 13, 2023
@pwithnall pwithnall merged commit e49b7ca into main Sep 13, 2023
@pwithnall pwithnall deleted the fix-appdata-caption-ending branch September 13, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate AppData file failed on Flathub
2 participants