More psi-monitor info #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The more proper way to do this would be to determine them in configure, but for such a basic C program I think we can just blindly turn them all on and error on warnings. https://phabricator.endlessm.com/T35318
Very basic `getopt_long` usage to allow adding options. https://phabricator.endlessm.com/T35318
Show the current pressure, the threshold and the recovery time when triggering an OOM to give more of a clue about what's happening. https://phabricator.endlessm.com/T35318
|
Could we also have a cmdline arg to adjust the 10% default threshold? Would be handy for experimenting with other values. |
Indeed, that's half the reason I added the option parsing, but then I forgot to do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get some more information out of
psi-monitorso we can see what's happening.https://phabricator.endlessm.com/T35318