overlay-setup: Ensure units ordered after /var overlay #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to create a list of units that require /var as in 0cddd9e is a losing game. It also doesn't really work properly since you can't order against all instances of a templated unit like [email protected]. As suggested by upstream[1], the more robust way to handle this is to order the service before var.mount. That requires handling the /var mount in the service, but fortunately that's straightforward for this narrow use case. With that change, the service will also run before ostree-remount.service, which means it has to take care of marking the /sysroot mount as private. Without that, the /var overlay mount will be mirrored under /sysroot. 1. systemd/systemd#32343 https://phabricator.endlessm.com/T35323
starnight
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to create a list of units that require /var as in 0cddd9e is a losing game. It also doesn't really work properly since you can't order against all instances of a templated unit like [email protected].
As suggested by upstream[1], the more robust way to handle this is to order the service before var.mount. That requires handling the /var mount in the service, but fortunately that's straightforward for this narrow use case.
With that change, the service will also run before ostree-remount.service, which means it has to take care of marking the /sysroot mount as private. Without that, the /var overlay mount will be mirrored under /sysroot.
https://phabricator.endlessm.com/T35323