repartition: Use partx rather than busybox partprobe #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since da7b937, partprobe in the initramfs is busybox, not the tool from parted. For unknown reasons, busybox partprobe fails to probe /dev/loop0 after it has been repartitioned, failing with: partprobe: /dev/loop0: Invalid argument partx --update performs a similar function, except that it works correctly at this stage of the boot process. Using partx also has the advantage that running this tool manually from the booted system (where partprobe is the real thing) will actually run the same code as in the initramfs. https://phabricator.endlessm.com/T35432
wjt
force-pushed
the
T35432-partx-not-busybox-partprobe
branch
from
d644efe
to
788fcf6
Compare
dbnicholson
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since da7b937, partprobe in the
initramfs is busybox, not the tool from parted.
For unknown reasons, busybox partprobe fails to probe /dev/loop0 after
it has been repartitioned, failing with:
partx --update performs a similar function, except that it works
correctly at this stage of the boot process. Using partx also has the
advantage that running this tool manually from the booted system (where
partprobe is the real thing) will actually run the same code as in the
initramfs.
https://phabricator.endlessm.com/T35432