eos-test-mode: Remount eos-live overlays in some services' namespace #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbnicholson
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
I think this is good enough, but I had a suggestion on matching PIDs and catching more affected mounts. I'll also note that this would always restart the services since the overlay mount would come later in the mount list. For this special purpose script, I don't think we need to get too careful, though.
Some systemd services start before execute eos-test-mode. And, if they mount the real storage blocks to paths under /sysroot in their namespace directly, then the modification under those paths will be kept, even "test mode" is finished. Therefore, the filesystem is not fresh new for the real end-user. This is caused by ostree making the /sysroot mount private. This commit remounts the eos-live overlays by restarting the systemd services which mount a real storage block to paths under /systemd in their namespace. https://phabricator.endlessm.com/T35625
starnight
force-pushed
the
T35625-service-remount-in-namespace
branch
from
e080421
to
28e58e8
Compare
dbnicholson
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systemd services start before execute eos-test-mode. And, if they mount the real storage blocks to /home in their namespace directly, then the modification under /home will be kept, even "test mode" is finished. Therefore, the filesystem is not fresh new for the real end-user.
This commit remounts the eos-live overlays by restarting the systemd services which mount a real storage block to /home in their namespace.
https://phabricator.endlessm.com/T35625