Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap transforms to pixels #54

Closed
wants to merge 1 commit into from
Closed

Snap transforms to pixels #54

wants to merge 1 commit into from

Conversation

manuq
Copy link
Contributor

@manuq manuq commented Jan 24, 2025

This is a recommended setting for low resolution pixel-art games. Exactly this case. It will help instantiating Player or Goober scenes directly into the canvas.

Helps #34

This is a recommended setting for low resolution pixel-art games.
Exactly this case. It will help instantiating Player or Goober scenes
directly into the canvas.

Helps #34
Copy link
Member

@wjt wjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR:

Screencast.from.2025-01-28.15-45-52.webm

And without it:

Screencast.from.2025-01-28.15-47-14.webm

I find the stuttering motion with this PR quite unpleasant to look at. That's consistent with the documentation:

This can lead to a crisper appearance at the cost of less smooth movement

So personally I think we should not make this change.

@manuq
Copy link
Contributor Author

manuq commented Jan 28, 2025

OK @wjt ! Per the GDD this is "retro, pixel-art visual style and feel" so I thought it was worth adding. But many retro-like games are flexible on things like this, in unlimited palette, etc. So I'll close it.

The other thing that this helps is in avoiding subpixel interpolation when instantiating scenes and positioning them in the canvas. But for that there is the "snap to pixel" canvas option which is turned on by default.

@manuq manuq closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants