Skip to content

Commit

Permalink
Send commit SHA to asset library API
Browse files Browse the repository at this point in the history 
Attempting to use the tag fails with:

    {
        "error": "Using Git tags or branches is no longer supported. Please give a full Git commit hash instead, or use the Custom download provider for GitHub Releases downloads."
    }

Use the commit hash instead, as described in the action documentation.

https://phabricator.endlessm.com/T35503
  • Loading branch information
@wjt
wjt committed Jun 28, 2024
1 parent ea8ac79 commit 3daad38
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion asset-template.json.hb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"cost": "MIT",
"support_level": "community",
"download_provider": "GitHub",
"download_commit": "{{ context.release.tag_name }}",
"download_commit": "{{ env.GITHUB_SHA }}",

This comment has been minimized.

Sign in to view

Copy link
@dbnicholson

dbnicholson Jun 28, 2024

Member

That's too bad. My worry is that if we change this action to also trigger on workflow_dispatch, then GITHUB_SHA might point to an untagged commit. I guess if we do add that, then we'd want to add some validation that GITHUB_REF starts with refs/tags/. We did something similar in kolibri-explore-plugin. For the record, I think you could also access this from {{ context.github.sha }}.
"browse_url": "{{ context.repository.html_url }}",
"issues_url": "{{ context.repository.html_url }}/issues",
"icon_url": "https://raw.githubusercontent.com/endlessm/godot-block-coding/{{ context.release.tag_name }}/icon.png"
Expand Down

0 comments on commit 3daad38

Please sign in to comment.