BlockCanvas: Implement drag & drop the file from resource FileSystem #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract dropping nodes codes as function _drop_node from _drop_data, if the type is "nodes". So, other types such as "obj_property" can be added later. https://phabricator.endlessm.com/T35649
Dragging the node's property from Inspector shows the object's type as "obj_property". So, allow the "obj_property" type in _can_drop_data() and handle it in _drop_data(). Then, implement getting the property's value as a Variable block with _drop_obj_property() in detail. https://phabricator.endlessm.com/T35649
… if CTRL is pressed Drag & drop the node's set property block from Inspector if the modifier key CTRL is pressed. To detect pressing CTRL key, hook the input event and set the _modifier_ctrl flag with the CTRL key's pressed state. If the _modifier_ctrl is true, then drop a set Variable block. Otherwise, it should be a get Variable block of the property. https://phabricator.endlessm.com/T35649
|
This depends on #296. So, set it as draft now. |
|
Here is the demo video: Screencast.From.2024-11-05.16-28-04.mp4 |
Dragging the files from resource FileSystem shows the files' type as "files". So, allow the "files" type in _can_drop_data() and handle it in _drop_data(). Then, implement getting the files' resource paths as Variable blocks with _drop_files() in detail. https://phabricator.endlessm.com/T35712
starnight
force-pushed
the
T35712-drag-drop-resource-file
branch
from
a5ce51c
to
c838758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dragging the files from resource FileSystem shows the files' type as
"files". So, allow the "files" type in _can_drop_data() and handle it in
_drop_data(). Then, implement getting the files' resource paths as
Variable blocks with _drop_files() in detail.
https://phabricator.endlessm.com/T35712