CI & linting improvements #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, half of the README was wrapped at 80 characters, while the other half used one long line per paragraph. It doesn't really matter which style is used; but it's nice to be consistent.
A minimal editorconfig to set the file encoding keeps being added to my working copy – I think by Godot 4.4-dev3 – so let's commit it, and add some potentially-useful rules for editing .gd files in external editors.
For rationale, see <https://turso.tech/blog/simple-trick-to-save-environment-and-money-when-using-github-actions>. For the linting & formatting action, the concurrency group is set to contain the PR (if any) and ref otherwise, on the basis that only the latest push to a PR or branch is interesting. For the GitHub Pages and Godot Asset Library actions, each run overwrites the result of any previous run, so the concurrency group is just the workflow name.
The change in question was released in 4.3.0, released in August.
manuq
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: