Drop downstream patches #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue of invalid load options after updating the ESP UUID will be solved by updating the load options when the UUID is changed. That makes these patches unnecessary. https://phabricator.endlessm.com/T31604
dbnicholson
force-pushed
the
T31604-drop-patches
branch
from
7d0f92a
to
db7c032
Compare
wjt
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on endlessm/eos-boot-helper#415. Presuming that's merged, then the load option will be updated with the new ESP partition UUID on first boot. Then there's no need for fallback to clean up invalid load options.
https://phabricator.endlessm.com/T31604
Reminder that this is just a holding ground for the changes since we don't currently have any tooling to automatically go from these git-buildpackage style branches to source package in OBS.