Skip to content

Commit

Permalink
fixup! review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
erights committed Aug 26, 2024
1 parent c05cb4f commit 4825656
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 53 deletions.
51 changes: 0 additions & 51 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -231,57 +231,6 @@ jobs:
- name: Run yarn test262
run: exit 0 # TODO remove test262 from required tests for CI

platform-compatibility-test:
name: platform-compatibility-test

# begin macro

runs-on: ${{ matrix.platform }}
strategy:
fail-fast: false
matrix:
node-version: [18.x, 20.x]
platform: [ubuntu-latest]

steps:
- name: Checkout
uses: actions/checkout@v3

# without this, setup-node errors on mismatched yarn versions
- run: corepack enable

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: yarn

- name: Echo node version
run: node --version

- name: Install dependencies
run: yarn install --immutable

# end macro

- name: 'build'
run: yarn run build

# fails under Node v17
- run: corepack disable

- name: 'switch to node v18'
uses: actions/setup-node@v3
with:
node-version: '18.x'

- name: Echo node version
run: node --version

- name: Run test:platform-compatibility
# npm b/c Yarn 4 doesn't work in Node 18
run: cd packages/ses && npm run test:platform-compatibility

viable-release:
name: viable-release

Expand Down
3 changes: 1 addition & 2 deletions packages/ses/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@
"lint:types": "tsc",
"prepare": "npm run clean && npm run build",
"qt": "ava",
"test": "tsd && ava",
"test:platform-compatibility": "node test/package/test.cjs"
"test": "tsd && ava"
},
"dependencies": {
"@endo/env-options": "workspace:^"
Expand Down

0 comments on commit 4825656

Please sign in to comment.