fix(ses): update console to print for Hermes VM

endojs · Sep 9, 2024 · 63645cf · 63645cf
1 parent e4a4f8c
commit 63645cf
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/packages/ses/src/commons.js b/packages/ses/src/commons.js
@@ -393,8 +393,14 @@ try {
 } catch (e) {
   if (e.name === 'SyntaxError') {
     // Swallows Hermes error `async generators are unsupported` at runtime.
-    // eslint-disable-next-line @endo/no-polymorphic-call
-    console.info('skipping async generators');
+    // @ts-ignore
+    // eslint-disable-next-line no-undef
+    print('SES: Skipping async generators, unsupported on Hermes');
+    // Note: `console` is not a JS built-in, so Hermes engine throws:
+    // Uncaught ReferenceError: Property 'console' doesn't exist
+    // See: https://github.com/facebook/hermes/issues/675
+    // However React Native provides a `console` implementation:
+    // https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Core/InitializeCore.js
   } else {
     throw e;
   }