squashme

endojs · Jan 17, 2024 · 8caf7f3 · 8caf7f3
1 parent 80dd1a4
commit 8caf7f3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/lockdown-canary.yml b/.github/workflows/lockdown-canary.yml
@@ -21,6 +21,7 @@ jobs:
 
       - name: Setup Chrome
         uses: browser-actions/setup-chrome@latest
+        ## location is OS dependent
         with:
           chrome-version: 'canary'
 
@@ -31,5 +32,5 @@ jobs:
 
       - name: Run tests
         run: |
-          echo "$(which google-chrome-unstable)" "$(which google-chrome)"
-          node ./packages/ses/smoke-test/index.js "$(which google-chrome-unstable)"
+          echo "$(which chrome)" "$(which google-chrome-unstable)" "$(which google-chrome)"
+          node ./packages/ses/smoke-test/index.js "$(which chrome)"
diff --git a/packages/ses/smoke-test/index.js b/packages/ses/smoke-test/index.js
@@ -1,8 +1,11 @@
 /* eslint-disable @endo/no-polymorphic-call */
+/* global process */
+
 import puppeteer from 'puppeteer-core';
 import assert from 'assert';
 
 const chromePath = process.argv[2];
+console.log(`chromePath ${chromePath}`);
 
 let browser;
 
@@ -43,6 +46,6 @@ async function runTests() {
 
 runTests().catch(error => {
   console.error(error);
-  browser.close();
+  browser&& browser.close();
   process.exit(1);
 });