Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(common): include utility modules in api-docs #2182

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

dckc
Copy link
Contributor

@dckc dckc commented Mar 26, 2024

refs: Agoric/documentation#1031

Description / Documentation Considerations

https://endojs.github.io/endo/modules/_endo_common.html says "Each utility is in its own top-level source file" but there are no links to them.

Security / Scaling / Testing / Compatibility / Upgrade Considerations

n/a

Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dckc
Copy link
Contributor Author

dckc commented Mar 26, 2024

What are the norms for merging in this repo? Do I use a label? or the github merge buttons?

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH merge button @dckc

@dckc dckc merged commit 1813f35 into master Mar 26, 2024
18 checks passed
@dckc dckc deleted the dc-common-doc branch March 26, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants