feat(ses,static-module-record): XS variants and parity test infrastructure #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
changed the title
kriskowal
force-pushed
the
kriskowal-ses-xs
branch
from
3af00c3
to
1a6c2ba
Compare
kriskowal
force-pushed
the
kriskowal-first-matching-tag
branch
from
78bc0f3
to
efdbaa1
Compare
kriskowal
force-pushed
the
kriskowal-first-matching-tag
branch
from
efdbaa1
to
5430a86
Compare
kriskowal
force-pushed
the
kriskowal-ses-xs
branch
from
1a6c2ba
to
460d851
Compare
kriskowal
force-pushed
the
kriskowal-first-matching-tag
branch
from
5430a86
to
7e7654d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #400
Description
This introduces an XS-specific variant on the SES and StaticModuleRecord packages and includes a suite of parity tests for ensuring equivalent behaviors between Node.js and XS.
The compatible flavor of XS is very specific. Endo’s Compartment Mapper provides a Rollup-analogue bundler that respects Node.js’s conditional imports and generates a single script we can run under
xstand could use to bootstrapxsnap. To use these XS contingent variants on SES and StaticModuleRecord, we must use Endo’s bundler with the"xs"tag.Security Considerations
We must take care to ensure that our parity tests cover (or at the very least spot-check) all the security properties of SES.
Scaling Considerations
We expect considerable performance improvement using XS-specific SES shim and ModuleSource variants on XS and other improvements to ecosystem health in general, discussed in #400.
Using an XS-specific variant of SES and StaticModuleRecord makes it possible to even contemplate bundling on XS. The native ModuleSource on XS performs considerably better than Babel on Node.js.
Documentation Considerations
None yet.
Testing Considerations
This change does not yet run these test suites under CI. Further work is needed to bring a specific verison of
xstinto CI and help developers reproduce thatxstversion as a local dependency. That may entail a submodule like Agoric SDK.Compatibility Considerations
This change seeks to adapt the native XS Compartment to the API of the SES emulation in order to preserve broad compatibility. The author leaves evolution of the SES Compartment API to better resemble the native XS Compartment as a future exercise.
Upgrade Considerations
None yet.