test: ci tests on node 22 rather than 21 #2322
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
approved these changes
Jun 17, 2024
erights
force-pushed
the
markm-2314-ci-on-node-22
branch
from
da06764
to
ceee421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2314
Refs: #2231 b11beba
Description
Now that nvm recognizes Node 22, we should probably redo the change from #2231 undone by b11beba .
Security Considerations
Whether our code works on Node 22 is much more relevant, including for security, than whether it works on Node 21. Indeed, until 22 could be used we were using Node 21 only for early warning about Node 22.
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
the point. Now that Node 22 is out, we should test on it.
Compatibility Considerations
Hopefully none
Upgrade Considerations
None