feat(import-bundle): Support endoScript #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-import-endo-script
branch
from
1de37c8
to
6c80a47
Compare
warner
approved these changes
Aug 29, 2024
packages/import-bundle/src/index.js
Outdated
| const result = compartment.evaluate(source); | ||
| if (moduleFormat === 'endoScript') { | ||
| // The completion value of an 'endoScript' is the namespace. | ||
| // This format does curry the filePrefix. |
There was a problem hiding this comment.
s/does/does not/ ? or did you mean the format holds the filePrefix internally somehow?
| inescapableGlobalValue: 42, | ||
| }, | ||
| }); | ||
| t.is(ns.default, 42); |
There was a problem hiding this comment.
Not really part of this PR, but should these tests exercise the "inescapability" of inescapableGlobalProperties ? Or did we decide that only the lexical-scope additions needed to be inescapable?
There was a problem hiding this comment.
looks like transforms being inescapable might be important too
There was a problem hiding this comment.
The test fixture is a module that runs in a Compartment and creates a child Compartment without options. So, all of these are verifying inescapability at least one level down.
export default new Compartment().evaluate('inescapableGlobalValue');
kriskowal
force-pushed
the
kriskowal-import-endo-script
branch
from
6c80a47
to
029330f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
endoScriptto theimportBundleruntime.Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
This change makes safe the assumption that all bundles produced by
bundleSourcecan be consumed byimportBundle.Testing Considerations
Unit tests included.
Compatibility Considerations
None.
Upgrade Considerations
None.