Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 95% CI error bars to CE and CW examples (Sourcery refactored) #16

Closed
wants to merge 1 commit into from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Nov 20, 2022

Pull Request #14 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the error_bars branch, then run:

git fetch origin sourcery/error_bars
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from endolith November 20, 2022 00:09
@@ -41,6 +41,7 @@
running as many simulations, however the Coombs results are consistently
high.
"""

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 97-97 refactored with the following changes:

@@ -24,6 +24,7 @@
| SU max | 100.0 | 84.1 | 79.6 | 78.4 | 77.3 | 77.5 |
| CW | 100.0 | 91.7 | 83.1 | 75.6 | 64.3 | 52.9 |
"""

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 54-132 refactored with the following changes:

This removes the following comments ( why? ):

# Likelihood of Condorcet Winner (normalized by n iterations)

for iteration in range(batch):
for _ in range(batch):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function func refactored with the following changes:

p = Parallel(n_jobs=-3, verbose=5)(delayed(func)() for i in range(n))
p = Parallel(n_jobs=-3, verbose=5)(delayed(func)() for _ in range(n))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 64-64 refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Nov 20, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.08%.

Quality metrics Before After Change
Complexity 26.30 😞 26.28 😞 -0.02 👍
Method Length 376.60 ⛔ 375.80 ⛔ -0.80 👍
Working memory 21.03 ⛔ 21.01 ⛔ -0.02 👍
Quality 24.28% 24.36% 0.08% 👍
Other metrics Before After Change
Lines 389 393 4
Changed files Quality Before Quality After Quality Change
examples/merrill_1984_fig_2c_2d.py 7.09% ⛔ 7.09% ⛔ 0.00%
examples/merrill_1984_table_1_fig_1.py 13.13% ⛔ 13.13% ⛔ 0.00%
examples/wikipedia_condorcet_paradox_likelihood.py 71.17% 🙂 71.17% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@endolith endolith closed this Nov 20, 2022
@endolith
Copy link
Owner

meh.

@endolith endolith deleted the sourcery/error_bars branch November 20, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant