Lts devel #2
Lts devel #2
Conversation
| export class GalyleoDocument extends DocumentWidget< | ||
| GalyleoEditor, | ||
| DocumentModel | ||
| > {} |
There was a problem hiding this comment.
You could also simply define a type.
| export class GalyleoDocument extends DocumentWidget< | |
| GalyleoEditor, | |
| DocumentModel | |
| > {} | |
| export type GalyleoDocument = DocumentWidget<GalyleoEditor, DocumentModel>; | |
| this.node.onmouseleave = () => (this._iframe.style.pointerEvents = 'none'); | ||
| this.node.onmousemove = (evt: MouseEvent) => { |
There was a problem hiding this comment.
You should add listeners in onAfterAttach and remove them in onBeforeDetach.
| setOption(key: string, value: any): void { | ||
| // do nothing | ||
| } | ||
|
|
||
| setOptions(options: Partial<CodeEditor.IConfig>): void { | ||
| // do nothing | ||
| } | ||
|
|
||
| getCursorPosition(): CodeEditor.IPosition { | ||
| return { | ||
| line: 0, | ||
| column: 0 | ||
| }; | ||
| } | ||
|
|
||
| getLine(lineNumber: number): string | null { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
There is no constrain in JupyterLab about the API of the content widget. So I would highly suggest keeping it simple.
| const extension: JupyterFrontEndPlugin<void> = { | ||
| id: PLUGIN_ID, | ||
| autoStart: true, | ||
| requires: [ |
There was a problem hiding this comment.
I would strongly recommend not depending on so many tokens. Try to make as many as possible optional - especially if you wish your extension to be compatible with Notebook v7.
Good candidate are ILabShell, ICommandPalette, ILauncher, IMainMenu, ITranslator, ISettingRegistry.
I'm not seeing the goal of requesting the trackers and try to use app.shell rather than requesting ILabShell otherwise your extension won't be compatible with notebook v7.
| <rect width="28" height="28" fill="black" fill-opacity="0"/> | ||
| <path d="M4 19H6V19.5H5V20.5H6V21H4V22H7V18H4V19ZM5 10H6V6H4V7H5V10ZM4 13H5.8L4 15.1V16H7V15H5.2L7 12.9V12H4V13ZM9 7V9H23V7H9ZM9 21H23V19H9V21ZM9 15H23V13H9V15Z" fill="#666666"/> | ||
| </svg> | ||
| <svg width="28" height="28" viewBox="0 0 28 28" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
I strongly advice you to use LabIcon registry and store only one version of your icons for all theme.
See https://github.com/jupyterlab/jupyterlab-git/blob/master/src/style/icons.ts
To have icon colors adapt to themes, you will need to define a class to the SVG; see
This is the PT for the LTS (Long-Term Sustainable) branch of the jupyterlab-universal-extension. It follows the directions in @fcollonval's PR, and should be an exact copy. The only reason this is being done as a separate branch/PR from #1 is to have a branch to compare code.