Support display of available video tracks as drop-down and to swap among them #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Mike @englishm
Re-opening this PR that had raised in Luke's repo , along with the code and description here.
with this PR have attempted to implement a provision to manually swap between video tracks on the Watch UI, without having to refresh/reload the page, as a first step towards ABR.
Please find below list of changes included in this PR:
With this PR in moq-rs , have added changes to dev/pub to enable us to create multiple video tracks ( 3 tracks ) and an audio track ingested as part of a single namespace via moq-pub , these tracks will be displayed as drop-down in moq-js Watch UI and user will be able to select a video track.
W.r.t to Unsubscribe sent from moq-js as of now we receive SUBSCRIBE_ERROR , code 1 , reason = cancelled from moq-relay , am not sure if it is the correct code in response, I would have to explore it further.
Another point I would like to bring your kind attention to is during UT, I observed this DOMException , i.e. Failed to execute 'decode' on 'VideoDecoder': A key frame is required after configure() or flush(), due to which I had to add a check to wait for keyframe at startup immediately after configure, it works and I no longer encounter the DOMException , but because of the initial wait for key frame at times there is a few sec of delay for stream play and we have to make FFmpeg send short interval keyframe , kindly advise whether we could handle it in a better way.
Kindly review and let me know your thoughts and amendments to be done.