Wayland fixes #368
Draft
Wayland fixes #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dtrip after intializing the protocols to ensure the compositor has enough time to send the activate and Done events to the client
…reate the objects
pentamassiv
force-pushed
the
wayland_fixes
branch
from
a0f34ca to
93a8b02
Compare
|
I think all fixes contained in this MR were upstreamed if #387 is merged. The other commits in this draft were only needed to find the errors and debug output. There is still a bug though and labwc crashes when entering simulating using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of fixes were needed for labwc. This still does not work and the commits need to get cleaned up. I think the keycode that gets sent with .key() is wrong. It's probably also wrong for the modifiers or the keymap does not have the needed modifiers. I hope that's the last issue.
So far I fixed the serial number when using the input_method protocol, the order in which the wayland objects get created, waiting for them to all exist before using them, the keymap now has the correct size. There are probably more fixes. I need to look at the commits again.
Another improvement would be to use the KeyMap that the compositor sends when first creating the virtual_keyboard object. That would make a lot of the mappings unneccessary. We should also use xkbcommon instead of creating the keymap manually.