Macro ring

[Master-Bw3]

No description provided.

[StellarWitch7]

Oh this'll be fun to review...

[StellarWitch7]

Regarding the following trick:

A version of this was already created on master previously, as documented below:

@Master-Bw3, @enjarai, and @Vlue, I'd like to keep only one of these. I personally prefer the one that accepts an address, as it's more versatile. But I'm not too set on the naming or pattern. Thoughts? (Pinging cotton as she was particularly interested in being able to get a list.)

[StellarWitch7]

I've made some changes that I'll push in a moment. Otherwise, the only issue I notice is that the macro map read/write tricks don't work if the ring is in the second slot. Also I'm sure enjarai has something to say about them being in the items category...

[StellarWitch7]

Oh last thing, I promise. It'd be nice if the trickster.spell.fragment.Map package didn't exist, and especially not capitalized in such a way. Perhaps Hamt would enjoy another home?

[StellarWitch7]

Anything I haven't covered, I've either touched in my commit, or it looks fine enough! Very nice PR, thank you.

[StellarWitch7]

The GitHub Actions build keeps failing, but even on a fresh clone of the repo it works for me... strange.

[StellarWitch7]

It's somehow my fault, but I don't know why...

[StellarWitch7]

Oh, the datagen fails on my machine. That's funny. Next commit should fix it.

[StellarWitch7]

Apart from the missing texture (and I think a model, too?), I think this is good to merge now!

[enjarai]

Texture added

[StellarWitch7]

Very important: worlds created with the latest commit, and in which a fragment is stored within an item, cannot be loaded once saved. This is a critical issue that must be addressed as soon as possible. The issue is likely in EndecTomfoolery or FragmentComponent and stems from the attempt to merge SpellComponent and MapComponent. Fixed.