[PLA-2154] Block processor issue

[leonardocustodio]

PR Type

Bug fix

---

Description

• Fixed incorrect variable usage in block syncing logic.

• Added exception handling with RestartIngestException.

• Improved logging for block synchronization process.

---

Changes walkthrough 📝

	Relevant files
Bug fix	BlockProcessor.php Fix and enhance block synchronization logic                            src/Services/Processor/Substrate/BlockProcessor.php Replaced lastBlockSynced with lastSyncedHeight for clarity. Added RestartIngestException to method documentation. Updated logging messages for better debugging. Adjusted logic to use the correct variable in block processing. +7/-4

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Issue The variable $lastSyncedHeight is used to replace $lastBlockSynced, but its calculation defaults to 0 if no block is found. This might lead to unintended behavior if no blocks are synced yet. Verify if this logic is correct and handles edge cases appropriately. $lastSyncedHeight = $this->lastSyncedBlock()?->number ?? 0; $blockBeforeSubscription = HexConverter::hexToUInt($heightHexed) - 1; $this->warn("Last block synced: {$lastSyncedHeight}"); $this->warn("Block before subscription: {$blockBeforeSubscription}"); if ($blockBeforeSubscription > $lastSyncedHeight) { $this->warn('Processing blocks left behind'); $this->fetchPastHeads($lastSyncedHeight, $blockBeforeSubscription); Exception Handling The @throws RestartIngestException annotation is added, but there is no clear indication in the code where this exception might be thrown. Ensure that this is either implemented or the annotation is removed. /** * @throws RestartIngestException */

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Validate input before hexadecimal conversion Validate that $heightHexed is a valid hexadecimal string before converting it with HexConverter::hexToUInt to prevent potential runtime errors. src/Services/Processor/Substrate/BlockProcessor.php [72] +if (!ctype_xdigit($heightHexed)) { + throw new InvalidArgumentException("Invalid hexadecimal string: {$heightHexed}"); +} $blockBeforeSubscription = HexConverter::hexToUInt($heightHexed) - 1; Suggestion importance[1-10]: 9 Why: Validating the input before conversion prevents potential runtime errors and ensures robustness, addressing a critical issue that could lead to unexpected failures.	9
General	Handle cases with no blocks left Ensure that the fetchPastHeads method handles cases where $lastSyncedHeight is greater than $blockBeforeSubscription to avoid unexpected behavior or errors. src/Services/Processor/Substrate/BlockProcessor.php [76-79] if ($blockBeforeSubscription > $lastSyncedHeight) { $this->warn('Processing blocks left behind'); $this->fetchPastHeads($lastSyncedHeight, $blockBeforeSubscription); $this->warn('Finished processing blocks left behind'); +} else { + $this->warn('No blocks left behind to process'); } Suggestion importance[1-10]: 7 Why: The suggestion adds a check for cases where no blocks are left to process, improving code clarity and handling edge cases. However, the impact is moderate as it does not address a critical bug or issue.	7