Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change enjin packages versions #49

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

leonardocustodio
Copy link
Contributor

@leonardocustodio leonardocustodio commented Aug 13, 2024

PR Type

enhancement, dependencies


Description

  • Updated the version constraints for enjin/platform-core, enjin/platform-beam, enjin/platform-fuel-tanks, enjin/platform-marketplace, and enjin/platform-ui packages from ^1.9 to ^1.0 in composer.json.

Changes walkthrough 📝

Relevant files
Dependencies
composer.json
Update version constraints for Enjin platform packages     

configs/core/composer.json

  • Updated version constraints for enjin/platform-* packages from ^1.9 to
    ^1.0
  • +5/-5     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Signed-off-by: Leonardo Custodio <[email protected]>
    @leonardocustodio leonardocustodio changed the title Update composer.json Change composer versions Aug 13, 2024
    @github-actions github-actions bot added enhancement New feature or request dependencies labels Aug 13, 2024
    @leonardocustodio leonardocustodio changed the title Change composer versions Change enjin packages versions Aug 13, 2024
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Version Downgrade
    The version constraints for the Enjin platform packages have been changed from '^1.9' to '^1.0'. This change represents a downgrade which might reintroduce previously fixed bugs or remove features that were added in versions after 1.0. It is crucial to ensure that this change is intentional and that all dependencies are compatible with these older versions.

    Copy link

    github-actions bot commented Aug 13, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Specify a more precise version range for the Enjin packages to ensure compatibility

    Consider specifying a more precise version range for the Enjin packages to avoid
    potential compatibility issues with future major updates. Using caret (^) allows
    updates that do not modify the left-most non-zero digit in the version, which might
    introduce breaking changes unintentionally if major versions are updated.

    configs/core/composer.json [24-28]

    -"enjin/platform-core": "^1.0",
    -"enjin/platform-beam": "^1.0",
    -"enjin/platform-fuel-tanks": "^1.0",
    -"enjin/platform-marketplace": "^1.0",
    -"enjin/platform-ui": "^1.0",
    +"enjin/platform-core": "~1.0",
    +"enjin/platform-beam": "~1.0",
    +"enjin/platform-fuel-tanks": "~1.0",
    +"enjin/platform-marketplace": "~1.0",
    +"enjin/platform-ui": "~1.0",
     
    Suggestion importance[1-10]: 8

    Why: The suggestion to use a more precise version range (using tilde ~ instead of caret ^) is valid as it helps avoid potential compatibility issues with future major updates. This is a best practice for maintaining stable dependencies.

    8

    @leonardocustodio leonardocustodio self-assigned this Aug 13, 2024
    @leonardocustodio leonardocustodio merged commit 82525db into master Aug 13, 2024
    1 check passed
    @leonardocustodio leonardocustodio deleted the change-composer-versions branch August 13, 2024 09:36
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Development

    Successfully merging this pull request may close these issues.

    3 participants